Skip to content

Move middleware sources to server/middleware - #793

Merged
bajtos merged 1 commit into
masterfrom
feature/move-middleware-to-conventional-location
Nov 13, 2014
Merged

bajtos merged 1 commit into
masterfrom
feature/move-middleware-to-conventional-location

Conversation

@bajtos

@bajtos bajtos commented Nov 12, 2014

Copy link
Copy Markdown
Member

The new location allows developer to use the following identifiers
when loading the middleware using the new declarative style:

app.middlewareFromConfig(
  require('loopback/server/middleware/rest'),
  { phase: 'routes' });

app.middlewareFromConfig(
  require('loopback/server/middleware/url-not-found'),
  { phase: 'final' });

/to @raymondfeng @ritch Please review. The convention introduced here should become the standard for all loopback components.

The new location allows developer to use the following identifiers
when loading the middleware using the new declarative style:

    app.middlewareFromConfig(
      require('loopback/server/middleware/rest'),
      { phase: 'routes' });

    app.middlewareFromConfig(
      require('loopback/server/middleware/url-not-found'),
      { phase: 'final' });
@bajtos
bajtos force-pushed the feature/move-middleware-to-conventional-location branch from 8a9a452 to 7fc66a1 Compare November 12, 2014 11:44
@bajtos bajtos added this to the #Epic: Components milestone Nov 12, 2014
@ritch

ritch commented Nov 12, 2014

Copy link
Copy Markdown
Member

LGTM

@ritch ritch assigned bajtos and unassigned ritch Nov 12, 2014
bajtos added a commit that referenced this pull request Nov 13, 2014
…nventional-location

Move middleware sources to `server/middleware`
@bajtos
bajtos merged commit d4ec1ab into master Nov 13, 2014
@bajtos bajtos removed the #review label Nov 13, 2014
@bajtos
bajtos deleted the feature/move-middleware-to-conventional-location branch November 13, 2014 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants